anmolnar commented on a change in pull request #1233: ZOOKEEPER-3701 Split
brain on log disk full
URL: https://github.com/apache/zookeeper/pull/1233#discussion_r370159576
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileSnap.java
##########
@@ -260,6 +260,8 @@ public synchronized void serialize(
Util.getZxidFromName(snapShot.getName(),
SNAPSHOT_FILE_PREFIX),
snapShot.lastModified() / 1000);
}
+ } else {
+ throw new IllegalStateException("FileSnap has already been
closed");
Review comment:
@ivankelly @eolivelli This is the serialize() method of FileSnap. Call chain
is:
FileSnap.serialize() <- FileTxnSnapLog.save() <-
ZooKeeperServer.takeSnapshot()
`takeSnapshot()` catches IOException and call system exit with error code of
`TXNLOG_ERROR_TAKING_SNAPSHOT`. Sounds like this should be the expected
behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
