maoling commented on a change in pull request #934: ZOOKEEPER-3301:Enforce the
quota limit
URL: https://github.com/apache/zookeeper/pull/934#discussion_r383114160
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/KeeperException.java
##########
@@ -403,7 +407,11 @@ public void setCode(int code) {
/** The session has been closed by server because server requires
client to do SASL authentication,
* but client is not configured with SASL authentication or
configuted with SASL but failed
* (i.e. wrong credential used.). */
- SESSIONCLOSEDREQUIRESASLAUTH(-124);
+ SESSIONCLOSEDREQUIRESASLAUTH(-124),
+ /** Exceeded the count quota that setted on the path.*/
+ COUNTQUOTAEXCEEDED(-125),
+ /** Exceeded the bytes quota that setted on the path.*/
+ BYTEQUOTAEXCEEDED(-126);
Review comment:
> The patch is very big. A better approach would be to split the patch into
smaller patches
the patch
- Although the patch is a little big, the implementation is straightforward
and simple, and lots of codes are written only for testing.
- They're all in one, I cannot split them. If I split the server and CLI
codes, it's not easy for me to test the changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
