maoling commented on a change in pull request #934: ZOOKEEPER-3301:Enforce the
quota limit
URL: https://github.com/apache/zookeeper/pull/934#discussion_r405510979
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/DelQuotaCommand.java
##########
@@ -43,11 +42,14 @@
private CommandLine cl;
public DelQuotaCommand() {
- super("delquota", "[-n|-b] path");
+ super("delquota", "[-n|-b|-N|-B] path");
OptionGroup og1 = new OptionGroup();
- og1.addOption(new Option("b", false, "bytes quota"));
- og1.addOption(new Option("n", false, "num quota"));
+ og1.addOption(new Option("n", false, "num soft quota"));
+ og1.addOption(new Option("b", false, "bytes soft quota"));
+ og1.addOption(new Option("N", false, "num hard quota"));
+ og1.addOption(new Option("B", false, "bytes hard quota"));
Review comment:
- Yes it's doable. Please create another ticket for it.
- using `OptionGroup `will have that inconvenient, which making options
exclusive in one client session.
- For the fix, no need to restart? just replace `OptionGroup `to `Option`,
then check the args length in the code?
- You can also create a ticket for this issue you found:
`if (f (parentName.startsWith(prh(procZookeeper)
&&Quotas.limitNode.equals(chi(childName)) `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
