symat commented on issue #1252: ZOOKEEPER-3726: invalid ipv6 address comparison URL: https://github.com/apache/zookeeper/pull/1252#issuecomment-591917686 LGTM in general, nice catch! We already have similar logics here: https://github.com/apache/zookeeper/blob/db87335fd2593cacc49bc23c1b9065256d0d3d36/zookeeper-client/zookeeper-client-c/src/zookeeper.c#L4957-L4992 It would be great to add a unit test for it (both for IPv4 and IPv6), but it seems to be a complicated issue to reproduce with unit tests. Please think about it. But I am OK to commit this without tests as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
