vtyulb commented on issue #1252: ZOOKEEPER-3726: invalid ipv6 address comparison URL: https://github.com/apache/zookeeper/pull/1252#issuecomment-592744082 Well, for sure it's almost impossible to reproduce full problem behavior. But it's possible to show how new addrvec_contains differs from the old one. In second commit I generate all addresses that differ by one bit from source. These tests can't pass on previous implementation. Also, I found 2 duplicate tickets for my issue: https://issues.apache.org/jira/browse/ZOOKEEPER-1677 https://issues.apache.org/jira/browse/ZOOKEEPER-2490 Both tickets have patches attached. ZOOKEEPER-2490 is not very elegant, but ZOOKEEPER-1677 even had tests (on which mine are based now). I am not really sure why they weren't merged, it looks like I am not the first one to encounter the bug.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
