ctubbsii commented on a change in pull request #1314: ZOOKEEPER-3791: Miscellaneous Maven fixes URL: https://github.com/apache/zookeeper/pull/1314#discussion_r406567410
########## File path: zookeeper-client/zookeeper-client-c/pom.xml ########## @@ -28,26 +28,21 @@ </parent> <artifactId>zookeeper-client-c</artifactId> - <packaging>jar</packaging> Review comment: No. Most of the plugins that are bound to the lifecycle by default for the jar packaging are smart enough to observe that there was no work for them to do. However, it is still wasteful to have these plugins execute at all. Changing the packaging type stops those plugins from executing pointlessly, because they are not bound to the lifecycle in the first place. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
