ctubbsii commented on a change in pull request #1314: ZOOKEEPER-3791:
Miscellaneous Maven fixes
URL: https://github.com/apache/zookeeper/pull/1314#discussion_r406938756
##########
File path: pom.xml
##########
@@ -265,15 +265,8 @@
<id>fatjar</id>
<modules>
<module>zookeeper-it</module>
- <module>zookeeper-contrib/zookeeper-contrib-fatjar</module>
Review comment:
Activating the `fatjar` profile will already activate it in the
`zookeeper-contrib` parent pom, which activates the the
`zookeeper-contrib-fatjar` under that.
Activating it here is redundant, and breaks when you also activate the
`full-build` profile.
Removing it here fixes that breakage when both profiles are activated.
To simplify things, I recommend merging the `full-build` and `fatjar`
profiles, so that there is a single `full-build` profile that creates the
fatjar with all the other contribs. Alternatively, if you want to build the
fatjar without the contribs, I recommend moving the fatjar to a module outside
of the contribs, so that activation doesn't conflict with the `full-build`
profile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
