muse-dev[bot] commented on a change in pull request #1526: URL: https://github.com/apache/zookeeper/pull/1526#discussion_r519656149
########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/embedded/ZooKeeperServerEmbeddedImpl.java ########## @@ -0,0 +1,164 @@ +package org.apache.zookeeper.server.embedded; + +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; +import java.io.OutputStream; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.Map; +import java.util.Properties; +import org.apache.zookeeper.server.DatadirCleanupManager; +import org.apache.zookeeper.server.ExitCode; +import org.apache.zookeeper.server.ServerConfig; +import org.apache.zookeeper.server.ZooKeeperServerMain; +import org.apache.zookeeper.server.quorum.QuorumPeer; +import org.apache.zookeeper.server.quorum.QuorumPeerConfig; +import org.apache.zookeeper.server.quorum.QuorumPeerMain; +import org.apache.zookeeper.util.ServiceUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the + * License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing permissions and limitations under the License. + */ +/** + * Implementation + */ +@SuppressFBWarnings("DM_EXIT") +class ZooKeeperServerEmbeddedImpl implements ZooKeeperServerEmbedded { + + private static final Logger LOG = LoggerFactory.getLogger(ZooKeeperServerEmbeddedImpl.class); + + private final QuorumPeerConfig config; + private QuorumPeerMain maincluster; + private ZooKeeperServerMain mainsingle; + private Thread thread; + private DatadirCleanupManager purgeMgr; + private final ExitHandler exitHandler; + private volatile boolean stopping; + + ZooKeeperServerEmbeddedImpl(Properties p, Path baseDir, ExitHandler exitHandler) throws Exception { + if (!p.containsKey("dataDir")) { + p.put("dataDir", baseDir.resolve("data").toAbsolutePath().toString()); + } + Path configFile = Files.createTempFile(baseDir, "zookeeper.configuration", ".properties"); + try (OutputStream oo = Files.newOutputStream(configFile)) { + p.store(oo, "Automatically generated at every-boot"); + } + this.exitHandler = exitHandler; + LOG.info("Current configuration is at {}", configFile.toAbsolutePath()); + config = new QuorumPeerConfig(); + config.parse(configFile.toAbsolutePath().toString()); + LOG.info("ServerID:" + config.getServerId()); + LOG.info("DataDir:" + config.getDataDir()); + LOG.info("Servers:" + config.getServers()); Review comment: *NULL_DEREFERENCE:* object `ZooKeeperServerEmbeddedImpl.config.quorumVerifier` last assigned on line 56 could be null and is dereferenced by call to `getServers()` at line 60. ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/embedded/ZooKeeperServerEmbeddedImpl.java ########## @@ -0,0 +1,164 @@ +package org.apache.zookeeper.server.embedded; + +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; +import java.io.OutputStream; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.Map; +import java.util.Properties; +import org.apache.zookeeper.server.DatadirCleanupManager; +import org.apache.zookeeper.server.ExitCode; +import org.apache.zookeeper.server.ServerConfig; +import org.apache.zookeeper.server.ZooKeeperServerMain; +import org.apache.zookeeper.server.quorum.QuorumPeer; +import org.apache.zookeeper.server.quorum.QuorumPeerConfig; +import org.apache.zookeeper.server.quorum.QuorumPeerMain; +import org.apache.zookeeper.util.ServiceUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the + * License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing permissions and limitations under the License. + */ +/** + * Implementation + */ +@SuppressFBWarnings("DM_EXIT") +class ZooKeeperServerEmbeddedImpl implements ZooKeeperServerEmbedded { + + private static final Logger LOG = LoggerFactory.getLogger(ZooKeeperServerEmbeddedImpl.class); + + private final QuorumPeerConfig config; + private QuorumPeerMain maincluster; + private ZooKeeperServerMain mainsingle; + private Thread thread; + private DatadirCleanupManager purgeMgr; + private final ExitHandler exitHandler; + private volatile boolean stopping; + + ZooKeeperServerEmbeddedImpl(Properties p, Path baseDir, ExitHandler exitHandler) throws Exception { + if (!p.containsKey("dataDir")) { + p.put("dataDir", baseDir.resolve("data").toAbsolutePath().toString()); + } + Path configFile = Files.createTempFile(baseDir, "zookeeper.configuration", ".properties"); + try (OutputStream oo = Files.newOutputStream(configFile)) { + p.store(oo, "Automatically generated at every-boot"); + } + this.exitHandler = exitHandler; + LOG.info("Current configuration is at {}", configFile.toAbsolutePath()); + config = new QuorumPeerConfig(); + config.parse(configFile.toAbsolutePath().toString()); Review comment: *CRLF_INJECTION_LOGS:* This use of org/slf4j/Logger.info(Ljava/lang/String;)V might be used to include CRLF characters into log messages [(details)](https://find-sec-bugs.github.io/bugs.htm#CRLF_INJECTION_LOGS) ########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/embedded/ZooKeeperServerEmbeddedImpl.java ########## @@ -0,0 +1,164 @@ +package org.apache.zookeeper.server.embedded; + +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; +import java.io.OutputStream; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.Map; +import java.util.Properties; +import org.apache.zookeeper.server.DatadirCleanupManager; +import org.apache.zookeeper.server.ExitCode; +import org.apache.zookeeper.server.ServerConfig; +import org.apache.zookeeper.server.ZooKeeperServerMain; +import org.apache.zookeeper.server.quorum.QuorumPeer; +import org.apache.zookeeper.server.quorum.QuorumPeerConfig; +import org.apache.zookeeper.server.quorum.QuorumPeerMain; +import org.apache.zookeeper.util.ServiceUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the + * License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing permissions and limitations under the License. + */ +/** + * Implementation + */ +@SuppressFBWarnings("DM_EXIT") +class ZooKeeperServerEmbeddedImpl implements ZooKeeperServerEmbedded { + + private static final Logger LOG = LoggerFactory.getLogger(ZooKeeperServerEmbeddedImpl.class); + + private final QuorumPeerConfig config; + private QuorumPeerMain maincluster; + private ZooKeeperServerMain mainsingle; + private Thread thread; + private DatadirCleanupManager purgeMgr; + private final ExitHandler exitHandler; + private volatile boolean stopping; + + ZooKeeperServerEmbeddedImpl(Properties p, Path baseDir, ExitHandler exitHandler) throws Exception { + if (!p.containsKey("dataDir")) { + p.put("dataDir", baseDir.resolve("data").toAbsolutePath().toString()); + } + Path configFile = Files.createTempFile(baseDir, "zookeeper.configuration", ".properties"); + try (OutputStream oo = Files.newOutputStream(configFile)) { + p.store(oo, "Automatically generated at every-boot"); + } + this.exitHandler = exitHandler; + LOG.info("Current configuration is at {}", configFile.toAbsolutePath()); + config = new QuorumPeerConfig(); + config.parse(configFile.toAbsolutePath().toString()); Review comment: *PATH_TRAVERSAL_IN:* This API (java/io/File.<init>(Ljava/lang/String;)V) reads a file whose location might be specified by user input [(details)](https://find-sec-bugs.github.io/bugs.htm#PATH_TRAVERSAL_IN) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
