eolivelli commented on a change in pull request #1526: URL: https://github.com/apache/zookeeper/pull/1526#discussion_r520341575
########## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/embedded/ZookeeperServerSslEmbeddedTest.java ########## @@ -0,0 +1,117 @@ +package org.apache.zookeeper.server.embedded; + +/** + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the + * License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + * implied. See the License for the specific language governing permissions and limitations under the License. + */ + +import static org.junit.Assert.assertTrue; +import java.io.File; +import java.io.IOException; +import java.nio.file.Path; +import java.util.Properties; +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.TimeUnit; +import org.apache.zookeeper.PortAssignment; +import org.apache.zookeeper.WatchedEvent; +import org.apache.zookeeper.ZooKeeper; +import org.apache.zookeeper.client.ZKClientConfig; +import org.apache.zookeeper.test.ClientBase; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; + +public class ZookeeperServerSslEmbeddedTest { + + @BeforeAll + public static void setUpEnvironment() { + System.setProperty("zookeeper.admin.enableServer", "false"); + System.setProperty("zookeeper.4lw.commands.whitelist", "*"); + } + + @AfterAll + public static void cleanUpEnvironment() throws InterruptedException, IOException { + System.clearProperty("zookeeper.admin.enableServer"); + System.clearProperty("zookeeper.4lw.commands.whitelist"); + System.clearProperty("java.security.auth.login.config"); + System.clearProperty("zookeeper.client.secure"); Review comment: I don't think so, we are using ZKClientConfig and not system properties in this case ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
