symat commented on a change in pull request #1519:
URL: https://github.com/apache/zookeeper/pull/1519#discussion_r519813881
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java
##########
@@ -467,26 +467,7 @@ public void logLatency(SummarySet metric, String key) {
* session
*/
Review comment:
also please extend the JavaDoc here, that not all users will be
returned, only the users which are belonged to a scheme "visible for auditing".
(as far as I can tell only audit logs used this method... maybe we could even
rename it to `getUsersForAudit`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
