ztzg commented on a change in pull request #1519:
URL: https://github.com/apache/zookeeper/pull/1519#discussion_r521496875
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/DigestAuthenticationProvider.java
##########
@@ -31,13 +31,26 @@
private static final Logger LOG =
LoggerFactory.getLogger(DigestAuthenticationProvider.class);
+ private static final String DIGEST_AUTH_ENABLED =
"zookeeper.DigestAuthenticationProvider.enabled";
+
/** specify a command line property with key of
* "zookeeper.DigestAuthenticationProvider.superDigest"
* and value of "super:<base64encoded(SHA1(password))>" to enable
* super user access (i.e. acls disabled)
*/
private static final String superDigest =
System.getProperty("zookeeper.DigestAuthenticationProvider.superDigest");
+ private static final boolean enabled;
Review comment:
Fixed.
(I had cargo-culted that fragment from `ZooKeeperServer.java`, and wanted to
keep the `{} = {}` log statement. It's a bit bizarre to now have a log
statement in an `isEnabled` method, but I suppose we can live with it as it's
only called once at startup. Other suggestions/pointers to "best practices"
welcome!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
