ztzg commented on pull request #1644:
URL: https://github.com/apache/zookeeper/pull/1644#issuecomment-858413588
Hi @li4wang,
> > Could you have a look? Do you know what is going on?
>
> Thanks a lot for reviewing it, @ztzg
>
> The test case has been fixed.
>
> The expected number of metrics should be 1 instead of 5 after the
QUOTA_EXCEEDED_ERROR_PER_NAMESPACE is changed from SummarySet to CounterSet.
Right; makes sense. The update looks good.
> All the test cases passed when I ran on my local. Can you please take a
quick look at it? Thanks.
LGTM. But I will let CI finish.
@eolivelli wrote:
> The failure seems related to this patch.
> I would like not to add a new flaky test
That was a failure was deterministic; the test had not been updated after
the introduction of the `CounterSet`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
