eolivelli commented on a change in pull request #1528:
URL: https://github.com/apache/zookeeper/pull/1528#discussion_r661484410
##########
File path:
zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java
##########
@@ -70,6 +70,7 @@
private Server server;
private final MetricsServletImpl servlet = new MetricsServletImpl();
private final Context rootContext = new Context();
+ public final CustomizedExports customizedExports =
CustomizedExports.instance();
Review comment:
why "public" ?
it is initialised in `configure` and you can stop it in the close method
no need to do something special in the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
