maoling commented on pull request #1528:
URL: https://github.com/apache/zookeeper/pull/1528#issuecomment-879870905


   > I am not sure we have to write the version to Prometheus. why do you want 
do to so ?
   
   @eolivelli 
   - The version info is a valuable metric for users to diagnose/report issues 
although we can find this from 
   other ways(e.g., log, JMX, zkServer.sh version).
   - A mature software should have this function  in its metric system. Let me 
give two example:
   
   ```
   Example A:
   JDK exposes its version metric like this:
   jvm_info{version="1.8.0_191-b12",vendor="Oracle 
Corporation",runtime="Java(TM) SE Runtime Environment",} 1.0
   
   Example B:
   Etcd exposes its version metric like this:
   curl -L http://localhost:2379/metrics
   # HELP etcd_server_version Which version is running. 1 for 'server_version' 
label with current version.
   # TYPE etcd_server_version gauge
   etcd_server_version{server_version="3.3.13"} 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to