jonmv commented on code in PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#discussion_r984913970
########## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java: ########## @@ -758,8 +759,9 @@ protected void syncWithLeader(long newLeaderZxid) throws Exception { FollowerZooKeeperServer fzk = (FollowerZooKeeperServer) zk; for (PacketInFlight p : packetsNotCommitted) { fzk.logRequest(p.hdr, p.rec, p.digest); + lastLoggedZxidFromDiff = p.hdr.getZxid(); } - packetsNotCommitted.clear(); + fzk.getZKDatabase().commit(); Review Comment: Hmm, need a rendevous with the sync processor thread for this to really guarantee anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org