jonmv commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1265066700
Actually, your version is better. I'm incorporating that here instead, if you don't mind? I still think it's a good idea to ensure the pending writes are actually flushed, before ack'ing the `NEWLEADER`, both because we _should ensure they're on persistent storage before ack'ing_, and also because that reduces the otherwise random order of `ACK`s the leader would observe, when `SyncRequestProcessor.run` races with `Learner.syncWithLeader`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
