jonmv commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1280715961
Hehe, yes, it's too complex. I'll try to extract that sync state state to a helper class, with descriptive method names. That should hopefully clarify the meaning of those two queues. And, yes, we need them both. I won't offer an explanation here, but rather hope the next commit makes that superfluous. Regarding the `isPreZAB1_0`: that must have been broken for some time as well—there's no `NEWLEADER` in the diff there, so we never start the ZK server (after that code was split and moved into the `NEWLEADER` handling. I can remove it in a separate commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
