PapaCharlie commented on code in PR #1950:
URL: https://github.com/apache/zookeeper/pull/1950#discussion_r1128985479
##########
zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatchManagerTest.java:
##########
@@ -416,6 +416,10 @@ private void checkMetrics(String metricName, long min,
long max, double avg, lon
assertEquals(sum, values.get("sum_" + metricName));
}
+ private void checkWatchedZxid(DumbWatcher watcher, long expectedZxid) {
+ assertEquals(expectedZxid, watcher.getWatchedZxid());
+ }
+
@ParameterizedTest
@MethodSource("data")
public void testWatcherMetrics(String className) throws IOException {
Review Comment:
You're right, this is worth testing. I've updated it, let me know what you
think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
