anmolnar commented on PR #2076: URL: https://github.com/apache/zookeeper/pull/2076#issuecomment-1757603444
> > I suggested the following in logback.xml config to enable JSON formatting. I think this approach doesn't require pulling additional dependencies. > > The main reason I discarded the contrib is since the project is/seems [no longer maintained](https://github.com/qos-ch/logback-contrib/releases/tag/v_0.1.5), last release in 2016, active CVEs not fixed.. Besides, Zookeeper distro does not include `logback-jackson` or `logback-json-classic`, so not available to users. > > My main motivation for selecting ECS JSON format is due to its popularity and OTEL selecting it. I cannot find template support for `JsonLayout`, so you'd need to implement a new `EcsJsonLayout` class in order to support that format, if I'm correct. > > Q: What does it mean that contrib JSON only supports logback classic? Q: What JSON schema does `JsonLayout` contrib output? There are so many different out there. Thanks @janhoy , I think ECS JSON is fine. I'm not familiar with JSON logging, but checking the website it looks like a widely accepted standard. Why do you need to add the version info? Is it part of the standard? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
