horizonzy commented on code in PR #2115:
URL: https://github.com/apache/zookeeper/pull/2115#discussion_r1466201702


##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java:
##########
@@ -169,24 +168,16 @@ public boolean isThrottlable() {
                 && this.type != OpCode.createSession;
     }
 
-    private transient byte[] serializeData;
-
-    @SuppressFBWarnings(value = "EI_EXPOSE_REP")
     public byte[] getSerializeData() {
         if (this.hdr == null) {
             return null;
         }
-
-        if (this.serializeData == null) {

Review Comment:
   See https://github.com/apache/zookeeper/pull/2030, the aim is to reduce the 
serialization. From the prd, the memory looks more sensitive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to