anmolnar commented on code in PR #2115:
URL: https://github.com/apache/zookeeper/pull/2115#discussion_r1484547484
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/TxnLogProposalIterator.java:
##########
@@ -58,20 +58,19 @@ public boolean hasNext() {
@Override
public Proposal next() {
- Proposal p = new Proposal();
+ Proposal p;
try {
byte[] serializedData = Util.marshallTxnEntry(itr.getHeader(),
itr.getTxn(), itr.getDigest());
QuorumPacket pp = new QuorumPacket(Leader.PROPOSAL,
itr.getHeader().getZxid(), serializedData, null);
- p.packet = pp;
- p.request = null;
-
+ p = new Proposal(pp);
// This is the only place that can throw IO exception
hasNext = itr.next();
} catch (IOException e) {
LOG.error("Unable to read txnlog from disk", e);
hasNext = false;
+ p = new Proposal();
Review Comment:
Weird to create objects in catch block, but it's okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
