eolivelli commented on code in PR #2114:
URL: https://github.com/apache/zookeeper/pull/2114#discussion_r1466377773
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java:
##########
@@ -528,7 +528,7 @@ private void receiveMessage(ByteBuf message) {
ZooKeeperServer zks = this.zkServer;
if (zks == null || !zks.isRunning()) {
LOG.info("Closing connection to {} because the
server is not ready",
- getRemoteSocketAddress());
+ getRemoteSocketAddress(), zks == null ? "null"
: zks.getState());
Review Comment:
maybe "UNKNOWN" is better than "null" here ?
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java:
##########
@@ -528,7 +528,7 @@ private void receiveMessage(ByteBuf message) {
ZooKeeperServer zks = this.zkServer;
if (zks == null || !zks.isRunning()) {
LOG.info("Closing connection to {} because the
server is not ready",
Review Comment:
it seem that you are not printing the state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
