soenkeliebau commented on code in PR #2114:
URL: https://github.com/apache/zookeeper/pull/2114#discussion_r1467548303
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java:
##########
@@ -528,7 +528,7 @@ private void receiveMessage(ByteBuf message) {
ZooKeeperServer zks = this.zkServer;
if (zks == null || !zks.isRunning()) {
LOG.info("Closing connection to {} because the
server is not ready",
- getRemoteSocketAddress());
+ getRemoteSocketAddress(), zks == null ? "null"
: zks.getState());
Review Comment:
super-nit: I think I'd prefer "unknown", by capitalizing it we suggest that
UNKNOWN is a variant of the State enum, whereas "unknown" would rather suggest
that we were unable to figure out the state.
But again, super-super-nitty comment and I have no strong opinion - might
just be my brain is wired weird to think about this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
