abhilash1in commented on code in PR #2117: URL: https://github.com/apache/zookeeper/pull/2117#discussion_r1514809146
########## zookeeper-docs/src/main/resources/markdown/zookeeperReconfig.md: ########## @@ -88,27 +88,41 @@ feature is disabled by default, and has to be explicitly turned on via ### Specifying the client port -A client port of a server is the port on which the server accepts -client connection requests. Starting with 3.5.0 the -_clientPort_ and _clientPortAddress_ configuration parameters should no longer be used. Instead, -this information is now part of the server keyword specification, which +A client port of a server is the port on which the server accepts plaintext (non-TLS) client connection requests +and secure client port is the port on which the server accepts TLS client connection requests. + +Starting with 3.5.0 the +_clientPort_ and _clientPortAddress_ configuration parameters should no longer be used in zoo.cfg. + +Starting with 3.9.2 the +_secureClientPort_ and _secureClientPortAddress_ configuration parameters should no longer be used in zoo.cfg. + +Instead, this information is now part of the server keyword specification, which becomes as follows: - server.<positive id> = <address1>:<port1>:<port2>[:role];[<client port address>:]<client port>** + server.<positive id> = <address1>:<port1>:<port2>[:role];[[<client port address>:]<client port>][;[<secure client port address>:]<secure client port>] Review Comment: Done ########## zookeeper-docs/src/main/resources/markdown/zookeeperReconfig.md: ########## @@ -88,27 +88,41 @@ feature is disabled by default, and has to be explicitly turned on via ### Specifying the client port -A client port of a server is the port on which the server accepts -client connection requests. Starting with 3.5.0 the -_clientPort_ and _clientPortAddress_ configuration parameters should no longer be used. Instead, -this information is now part of the server keyword specification, which +A client port of a server is the port on which the server accepts plaintext (non-TLS) client connection requests +and secure client port is the port on which the server accepts TLS client connection requests. + +Starting with 3.5.0 the +_clientPort_ and _clientPortAddress_ configuration parameters should no longer be used in zoo.cfg. + +Starting with 3.9.2 the Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
