anmolnar commented on code in PR #2117:
URL: https://github.com/apache/zookeeper/pull/2117#discussion_r1526945776
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java:
##########
@@ -322,8 +342,25 @@ private void initializeWithAddressString(String
addressStr, Function<InetSocketA
try {
clientAddr = new InetSocketAddress(clientHostName,
Integer.parseInt(clientParts[clientParts.length - 1]));
} catch (NumberFormatException e) {
- throw new ConfigException("Address unresolved: " +
hostname + ":" + clientParts[clientParts.length - 1]);
+ throw new ConfigException("Address unresolved: " +
clientHostName + ":" + clientParts[clientParts.length - 1]);
+ }
+ }
+
+ if (serverClientParts.length == 3 &&
!serverClientParts[2].isEmpty()) {
Review Comment:
This is only available from 3.10.0 which is a major upgrade and as far as I
know the code is able to read the old config, so backward compatibility is ok.
I guess Curator will support ZK 3.10.0 from a certain release where they'll add
the new config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
