kezhuw commented on code in PR #2117: URL: https://github.com/apache/zookeeper/pull/2117#discussion_r1527077740
########## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java: ########## @@ -322,8 +342,25 @@ private void initializeWithAddressString(String addressStr, Function<InetSocketA try { clientAddr = new InetSocketAddress(clientHostName, Integer.parseInt(clientParts[clientParts.length - 1])); } catch (NumberFormatException e) { - throw new ConfigException("Address unresolved: " + hostname + ":" + clientParts[clientParts.length - 1]); + throw new ConfigException("Address unresolved: " + clientHostName + ":" + clientParts[clientParts.length - 1]); + } + } + + if (serverClientParts.length == 3 && !serverClientParts[2].isEmpty()) { Review Comment: Yeh. I think, at the very least, users of Curator could pin their ZooKeeper to 3.10.0 before a Curator release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org