kezhuw commented on PR #2209: URL: https://github.com/apache/zookeeper/pull/2209#issuecomment-2499384241
> he input cert string has to be validated before being stored in cert_t There is no guarantee from our side. For invalid input, we have to do either: 1. Reports error. 2. Crashes eagerly. 3. Tolerates "invalid" input. This pr goes opposite as I pointed out in https://github.com/apache/zookeeper/pull/2209#issuecomment-2484562704. I am willing to accept either of above(I stated this in https://github.com/apache/zookeeper/pull/2209#issuecomment-2458627959 and https://github.com/apache/zookeeper/pull/2209#issuecomment-2466111427). Personally, I prefer the third as it is the current situation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
