Gowrima commented on PR #2209:
URL: https://github.com/apache/zookeeper/pull/2209#issuecomment-2506551082

   @kezhuw With the following code changes,
       zcert_t zcert;
       zcert.certstr = strdup(cert);
       zcert.ca = strtok(zcert.certstr, ",");
   
   and the following input,
   
init_(",,,/tmp/certs/server.crt,/tmp/certs/client.crt,/tmp/certs/clientkey.pem,password");
   
   the result is going to be,
   certstr = ,,,/tmp/certs/server.crt
    ca = /tmp/certs/server.crt
    cert = /tmp/certs/client.crt
   key = /tmp/certs/clientkey.pem
    password = password
   
   This is still not correct - certstr is not serving it's purpose (to hold the 
entire cert string as-is), but I will go ahead and keep this version of the 
fix. Since this is not a user-input from CLI, and hard-coded, we can make sure 
that the input string does not contain malicious characters. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to