li4wang commented on code in PR #2254:
URL: https://github.com/apache/zookeeper/pull/2254#discussion_r2121953646
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java:
##########
@@ -780,8 +803,8 @@ protected void syncWithLeader(long newLeaderZxid) throws
Exception {
continue;
}
packetsNotLogged.removeFirst();
- fzk.appendRequest(pif.hdr, pif.rec, pif.digest);
- fzk.processTxn(pif.hdr, pif.rec);
+ fzk.appendRequest(pif.toRequest());
+ fzk.processTxn(pif.toRequest());
Review Comment:
nitpick
How about create the request object and reuse it instead of converting twice?
```
Request request = pif.toRequest()
fzk.appendRequest(request)
fzk.processTxn（request)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
