li4wang commented on PR #2254: URL: https://github.com/apache/zookeeper/pull/2254#issuecomment-2932370939
The changes for fixing the data loss issue looks good. It's a very critical issue. Thanks for fixing it. The changes for blocking proposal and commit requests being out of order looks good in general, but please make sure it doesn't introduce any unexpected issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org