kezhuw commented on PR #2267: URL: https://github.com/apache/zookeeper/pull/2267#issuecomment-2978859022
Hi @vinayakumarb, does apache/curator#1252 solves your concerns ? > do you know the justification for making it final in the first place? I think it is because both `void shutdown()` and `void shutdown(boolean fullyShutDown)` are open to be overrode before the fix bc9afbf8ef1bc6156643d3d05c87fcf8411e9d8f to efbd660e1c4b90a8f538f2cccb5dcb7094cf9a22 which calls `shutdown(boolean fullyShutDown)` directly and bypass overrides in `shutdown()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
