vinayakumarb commented on PR #2267: URL: https://github.com/apache/zookeeper/pull/2267#issuecomment-2988789685
> The change seems simple enough, and beneficial, but do you know the justification for making it final in the first place? Will this introduce some regression because it fails to consider that original justification? There was no justification provided while making it final in the commit. This change as been done in a subminor version release and broken Curator's TestingZookeeperMain class. Because of this, upgrading to zookeeper 3.9.3 is blocked, which breaks the tests which are using `TestingZookeeperMain` from curator. in general, breaking changes are not advised in a subminor version. I totally agree that, `shutdown()` is not an API, but this change stops from adoption immediately. Change https://github.com/apache/curator/pull/1252 would solve the problem. But that needs a release from Curator and down streams needs to adopt that as well which are not as frequent as zookeeper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
