kezhuw commented on code in PR #2294:
URL: https://github.com/apache/zookeeper/pull/2294#discussion_r2278378370
##########
zookeeper-contrib/zookeeper-contrib-fatjar/pom.xml:
##########
@@ -90,10 +94,6 @@
<groupId>org.xerial.snappy</groupId>
<artifactId>snappy-java</artifactId>
</dependency>
- <dependency>
- <groupId>ch.qos.logback</groupId>
- <artifactId>logback-core</artifactId>
- </dependency>
Review Comment:
`logback-core` contains no integration with slf4j, so no logs from slf4j. I
confirmed this by running client mode of this fatjar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
