kezhuw commented on code in PR #2294:
URL: https://github.com/apache/zookeeper/pull/2294#discussion_r2278395599
##########
zookeeper-server/pom.xml:
##########
@@ -74,13 +74,10 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
- <dependency>
- <groupId>ch.qos.logback</groupId>
- <artifactId>logback-core</artifactId>
- </dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
+ <scope>test</scope>
Review Comment:
Turn out this is enough to go without `flatten-maven-plugin` as test
dependencies are <del>no</del> transitive and skipped by default in owasp
dependency-check.
https://jeremylong.github.io/DependencyCheck/dependency-check-maven/check-mojo.html#skipTestScope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
