On Mon, 16 May 2011 13:59:51 -0700, Carl Worth <cwo...@cworth.org> wrote: > So what I'd love to see from here is a commit with a description like > the above, and then a test case looking like your example. > > From there, I'd next like a new version of the commit that gets the > intended behavior with less code duplication. > > I'll work on each of the above unless someone beats me to any of it. Let > me know.
I've now pushed out my own version of the MIME restructuring feature. It differs from what was presented here in avoiding the code duplication. It also provides properly nested mutlipart/* output for the --format=text case. That's not that I expect anybody to *do* anything with that nested output, just that it was cleaner and easier to fix both text/json at the same time, (and avoiding doing that is perhaps what led to the original code duplication). I also cherry-picked in a piece of later patch from Jamie so that the existing emacs tests still pass. And I updated the documentation for this new feature. So I'm happy with this new feature now, (which I know provides an essential part of the basis for the rest of the crypto branch). From here, I'm hoping that my review of the rest of Jamie's release-candidate branch goes faster. The general shape of the commits and commit messages looks pretty good to me, so I think it will. I think there are still features added here and there without corresponding test cases (multipart/alternative is one that comes to mind) and perhaps without updated documentation (--decrypt is at least documented---but I do think it's strange that it's documented to only work for json output). More from me tomorrow. -Carl
Description: PGP signature
_______________________________________________ notmuch mailing list firstname.lastname@example.org http://notmuchmail.org/mailman/listinfo/notmuch