Quoth Dmitry Kurochkin on Dec 11 at 2:34 pm: > Hi Austin. > > I enjoyed reviewing this patch. It is a pleasure to see how complex and > confusing code becomes much smaller and cleaner. > > I still have some questions with the new code. It seems confusing to me > that part_content is called first and then go envelope headers. But I > this is just the first step of the rewrite, right? :)
Yeah, this is weird, but I'm just being compatible with the existing code at this point. This code is about to go away. > The only comment I have: > > + format->part_content (part); > > For all other format members that are function pointers, we have a check > for NULL. Perhaps we should add it here as well? I would if I weren't about to delete this. ]:--8) _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
