Well, thanks for the quick review :) I have updated all the patches to take your fixes into account, there is still the discussion left about the GC integration. Once we get that sorted out, I'll send the updated version.
Le 18/07/2012 23:51, Austin Clements a ?crit : > This series looks good to me other than the few things I commented on. > It's nice to see the Go bindings get a bit of love! > > Quoth Adrien Bustany on Jul 18 at 9:34 pm: >> The following patches fix some serious memory management issues with >> the Go bindings, and add some missing functions as well. >> >> Adrien Bustany (7): >> go: Use iota in enum bindings >> go: Add missing MESSAGE_FLAG_EXCLUDED in Flag enum >> go: Allow notmuch objects to be garbage collected >> go: Make Destroy functions safe to call several times >> go: Partially bind notmuch_database_upgrade >> go: Bind notmuch_database_find_message_by_filename >> go: Bind notmuch_thread_t functions >> >> bindings/go/src/notmuch/notmuch.go | 471 >> ++++++++++++++++++++++++++++++++++-- >> 1 files changed, 447 insertions(+), 24 deletions(-) >>