On Mon, Mar 13 2017, David Bremner <da...@tethera.net> wrote: > Tomi Ollila <tomi.oll...@iki.fi> writes: > >> Replaced use of sha256 (gnu coreutils binary) with more portable >> openssl sha256 execution. >> --- >> >> Works on Linux and also on my FreeBSD KVM environment. > > There's a tradeoff here. In a minimal GNU/Linux environment coreutils is > there but not openssl. So I don't mind the substitution (for the test
Köh... That did not come into my mind, but perhaps that is the fun of it. I'd rather let this test fail on non-coreutils system (for the time being) than introduce more dependencies ;) -- have to think whether proposing alternative solution... And had to test that one: localhost$ sudo docker run --rm -it debian:8.7 /bin/bash root@1c96aac39246:/# openssl bash: openssl: command not found root@1c96aac39246:/# sha1sum < /dev/null da39a3ee5e6b4b0d3255bfef95601890afd80709 - root@1c96aac39246:/# exit exit localhost$ Marking this particular patch obsolete. Tomi > suite), but I think you need to add a > "test_require_external prereq openssl" or equivalent to T530-upgrade.sh > > This will also require adding openssl as a debian build dependency; I > can also live with that, although it might inconvenience some people > building the debian-snapshot target. > > There's something aesthetically displeasing about hardcoding the > checksum into the test script but I think I'm just grumbling at this > point. I personally disagree (in specific cases like this), but would not have done that if there were simpler solution using the file... _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch