On Sun, Apr 08 2018, Floris Bruynooghe wrote:

> This series looks good to me, would be great to have!  Do you want to
> commit them this or should I just incorporate it and submit together
> with tests once actual tests exist.  You could always commit with a ``def
> test_dummy(): assert True`` or something if you like.

I'd say incorporate and submit, have some real tests, remove that
*known_broken* line and so on...

Tomi


>
> Thanks!
> Floris
>
>
> On Sat 07 Apr 2018 at 18:39 -0300, David Bremner wrote:
>
>> The 'test_subtest_known_broken' should be removed when there are
>> actual tests to run.
>>
>> Based on a function from Tomi [1]
>>
>> [1]: id:m2r2nq23r9....@guru.guru-group.fi
>> ---
>>  test/T391-pytest.sh | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>  create mode 100755 test/T391-pytest.sh
>>
>> diff --git a/test/T391-pytest.sh b/test/T391-pytest.sh
>> new file mode 100755
>> index 00000000..9ac7aabe
>> --- /dev/null
>> +++ b/test/T391-pytest.sh
>> @@ -0,0 +1,14 @@
>> +#!/usr/bin/env bash
>> +test_description="python bindings (pytest)"
>> +. $(dirname "$0")/test-lib.sh || exit 1
>> +
>> +test_require_external_prereq ${NOTMUCH_PYTHON}
>> +
>> +for bin in ${NOTMUCH_PYTEST_PYTHONS}; do
>> +    test_begin_subtest "pytest ($bin)"
>> +      test_subtest_known_broken
>> +       
>> PYTHONPATH="$NOTMUCH_SRCDIR/bindings/python${PYTHONPATH:+:$PYTHONPATH}" \
>> +                 test_expect_success "$bin -m pytest 
>> $NOTMUCH_SRCDIR/bindings/python"
>> +done
>> +
>> +test_done
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Reply via email to