On Wed, Feb 09 2022, Michael J. Gruber wrote: > T380.2 gives a test description which depends on the actual test output, > rather than the expected outcome or actual test which is performed. > > So, when the test fails due missing abort points, the test describes > itself as `detected 0>10 abort points` so that it's not clear which part > or which number is the expectation. (Also, `0>10` is no number ...) > > When the test is not run for some reason and fails because of that, the > test describes itself as `detected >10 abort points`, which arguably is > better or worse. > > Reword it to say `detected more than 10 abort points`, which is the > actual expectation and what we test for. The failing test line still > gives the actual number. > > Signed-off-by: Michael J Gruber <g...@grubix.eu> > --- > test/T380-atomicity.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh > index 7f618062..49df5c38 100755 > --- a/test/T380-atomicity.sh > +++ b/test/T380-atomicity.sh > @@ -99,7 +99,7 @@ fi > test_begin_subtest '"notmuch new" is idempotent under arbitrary aborts' > test_expect_equal_file expectall searchall > > -test_begin_subtest "detected $outcount>10 abort points" > +test_begin_subtest "detected more than 10 abort points"
probably ok (I trust the commit msg is right :D) > test_expect_success "test $outcount -gt 10" > > test_done > -- > 2.35.1.306.ga00bde9711 > > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-le...@notmuchmail.org _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
