Hello! These patches extract and enhance the bitfield support in the register macro in nova to define Rust structures with bitfields. It then moves out the bitfield support into the kenrel crate and further enhances it. This is extremely useful as it allows clean Rust structure definitions without requiring explicit masks and shifts.
See [1] example code using it. [1] https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/patch/?id=76797b31facae8f1a1be139412c78568df1da9f3 v4 of the patches are at: https://lore.kernel.org/all/[email protected]/ v3 of the patches are at: https://lore.kernel.org/all/[email protected]/ v2 of the patches are at: https://lore.kernel.org/all/[email protected]/ v1 of the patches are at: https://lore.kernel.org/all/[email protected]/ v4->v5: * Added 2 hardening patches to catch the misuse of the API. * Limited access to the inner value of the struct. * Fixed kunit tests * Addressed feedback from lots of folks (Miguel, Alexandre, Yury, Danilo). * Added Alex tags to most patches. v3->v4: * Rebased on -next. * Added more test cases. * Added support for fields larger than the struct (ex, using 'as u32' for a u8 struct.) v2->v3: * Renamed bitstruct to bitfield. * Various suggestions to improve code (Alex, Yury, Miguel). * Added reviewed-by tags from Elle Rhumsaa. * Added KUNIT tests including tests for overlap. * Added F: maintainers file entry for new files under BITOPS. v1->v2: * Use build_assert in bitstruct * Split move and enhance patches for easier review * Move out of Nova into kernel crate for other drivers like Tyr which will use. * Miscellaneous cosmetic improvements. Joel Fernandes (9): nova-core: bitfield: Move bitfield-specific code from register! into new macro nova-core: bitfield: Add support for different storage widths nova-core: bitfield: Add support for custom visiblity rust: Move register and bitfield macros out of Nova rust: bitfield: Add a new() constructor and raw() accessor rust: bitfield: Add KUNIT tests for bitfield rust: bitfield: Use 'as' operator for setter type conversion rust: bitfield: Add hardening for out of bounds access rust: bitfield: Add hardening for undefined bits MAINTAINERS | 7 + drivers/gpu/nova-core/falcon.rs | 2 +- drivers/gpu/nova-core/falcon/gsp.rs | 4 +- drivers/gpu/nova-core/falcon/sec2.rs | 2 +- drivers/gpu/nova-core/regs.rs | 6 +- rust/kernel/bitfield.rs | 804 ++++++++++++++++++ rust/kernel/io.rs | 1 + .../macros.rs => rust/kernel/io/register.rs | 317 +------ rust/kernel/lib.rs | 1 + security/Kconfig.hardening | 9 + 10 files changed, 870 insertions(+), 283 deletions(-) create mode 100644 rust/kernel/bitfield.rs rename drivers/gpu/nova-core/regs/macros.rs => rust/kernel/io/register.rs (72%) -- 2.34.1
