On Dec 9, 2025, at 10:41 PM, Zhi Wang <[email protected]> wrote: On Sat, 6 Dec 2025 21:32:51 -0500 Joel Fernandes <[email protected]> wrote:
Hi Zhi, On 12/6/2025 7:42 AM, Zhi Wang wrote: snip == 0x00000004); + + let val = bar.read32(0x88000 + 0xbfc); + info.b64bitBar2 = u8::from((val & 0x00000006) == 0x00000004); Please no magic numbers, please use proper named constants with documentation comments explaining the values. Also BAR reads here need proper register macro definitions/access. That is true. :) But this is because there is no register definition in the OpenRM code/non OpenRM code as well. I have no idea about the name and bit definitions of this register. Ah interesting. Let me also look into it on my side, see if I can find more information. Thanks for mentioning the challenge. Suppose I will have to find some clues from some folks then document them here when going to patches request for merged. :) Yes, I would say we definitely need to dig more into this ;) fun. Also the above code is lacking in comments. All the steps above need proper comments IMO. General philosophy of Nova is it is a well documented, cleanly written driver with minimal/no magic numbers and abundant comments. :) Agree. :) Thanks :) - Joel
