On Mon Dec 8, 2025 at 12:55 AM JST, Timur Tabi wrote:
> On Sat, 2025-12-06 at 12:42 +0000, Zhi Wang wrote:
>> - pub(crate) fn new() -> Self {
>> + pub(crate) fn new(vgpu_support: bool) -> Self {
>> + let num_entries = if vgpu_support { 4 } else { 3 };
>
> Instead of passing a bool, and then hard-coding the length based on that bool
> (which would
> require that RMSetSriovMode always be the last entry in the array), you need
> to do what Nouveau
> does: if VGPU is enabled, then dynamically append the entry to the array.
Yup, as we will add more stuff to the registry depending on various
conditions it would be great to make it more flexible.
The way for this would be to make `SetRegistry` wrap a `KVec` of
`RegistryEntry` - that way we can add what we need according to the
runtime options.
The current design of `SetRegistry` (which does not directly wraps the
type to write to the command queue, but instead implements
`CommandToGsp` to create it as the command is sent) should make this
rather trivial.
