On Fri, 2026-01-23 at 18:14 +0000, Gary Guo wrote:
> 
> > +/// On Turing and GA100, the entries in the `LibosMemoryRegionInitArgument`
> > +/// must all be a multiple of GSP_PAGE_SIZE in size, so add padding to 
> > force it
> > +/// to that size.
> > +#[repr(C)]
> > +pub(crate) struct GspArgumentsAligned {
> 
> Hi Timir,

Timur

> This is not "aligned" to GSP_PAGE_SIZE, but rather just "padded" to
> GSP_PAGE_SIZE, so calling it `GspArgumentsAligned` would be a misnomer.
> 
> `GspArgumentsPadded`, perhaps?

Well, this is Alex's patch, so if he wants to rename it if/when he pulls it in, 
that's up to him. 
This is already v8, I'm not keen on any more bike shedding.

Reply via email to