On 1/23/26 10:41 AM, Timur Tabi wrote:
> On Fri, 2026-01-23 at 18:14 +0000, Gary Guo wrote:
>>
>>> +/// On Turing and GA100, the entries in the `LibosMemoryRegionInitArgument`
>>> +/// must all be a multiple of GSP_PAGE_SIZE in size, so add padding to
>>> force it
>>> +/// to that size.
>>> +#[repr(C)]
>>> +pub(crate) struct GspArgumentsAligned {
>>
>> Hi Timir,
>
> Timur
>
>> This is not "aligned" to GSP_PAGE_SIZE, but rather just "padded" to
>> GSP_PAGE_SIZE, so calling it `GspArgumentsAligned` would be a misnomer.
>>
>> `GspArgumentsPadded`, perhaps?
>
> Well, this is Alex's patch, so if he wants to rename it if/when he pulls it
> in, that's up to him.
> This is already v8, I'm not keen on any more bike shedding.
>
To respond to Gary's feedback (as opposed to when and how to apply it),
I'd classify this as "polishing", rather than using the pejorative
"bike shedding". Because polishing clearly makes something a little bit
better, and I think there is no argument that the "padded" name makes
things objectively better: more accurate name, not longer, all good.
As for the when and how: yes, it's true that we may defer some
improvements, and I agree that we could do that in this case.
And...let's try to avoid (perhaps inadvertently) discouraging our
reviewers; we are lucky to have them.
thanks,
--
John Hubbard
