On 1/21/26 8:20 AM, Gary Guo wrote:
> On Wed Dec 3, 2025 at 5:59 AM GMT, John Hubbard wrote:
...
>> + read_poll_timeout(
>> + || {
>> + let released = Self::gsp_lockdown_released(
>> + dev,
>> + gsp_falcon,
>> + bar,
>> + fmc_boot_params_addr,
>> + &mut mbox0,
>> + );
>> +
>> + Ok((released, mbox0))
>> + },
>> + |(released, _)| *released,
>> + Delta::ZERO,
>> + Delta::from_millis(4000),
>> + )
>> + .inspect_err(|_| {
>> + dev_err!(dev, "GSP lockdown release timeout\n");
>> + })
>
> Once you're done with the error, please just return early with `?` and not
> keep
> chaining.
Done.
thanks,
--
John Hubbard
