Hi Brett,

Thanks for your comments. I've already made the necessary changes.


----- "Brett Porter" <br...@apache.org> wrote:

> On 19/10/2010, at 10:26 PM, apadi...@apache.org wrote:
> 
> > Added:
> incubator/npanday/npanday-its/trunk/src/test/java/npanday/its/NPandayITNet40Test.java
> > URL:
> http://svn.apache.org/viewvc/incubator/npanday/npanday-its/trunk/src/test/java/npanday/its/NPandayITNet40Test.java?rev=1024204&view=auto
> >
> ==============================================================================
> > ---
> incubator/npanday/npanday-its/trunk/src/test/java/npanday/its/NPandayITNet40Test.java
> (added)
> > +++
> incubator/npanday/npanday-its/trunk/src/test/java/npanday/its/NPandayITNet40Test.java
> Tue Oct 19 11:26:56 2010
> > @@ -0,0 +1,43 @@
> > +package npanday.its;
> > +
> > +/*
> > + * Copyright 2010
> > + *
> > + * Licensed under the Apache License, Version 2.0 (the "License");
> > + * you may not use this file except in compliance with the
> License.
> > + * You may obtain a copy of the License at
> > + *
> > + *     http://www.apache.org/licenses/LICENSE-2.0
> > + *
> > + * Unless required by applicable law or agreed to in writing,
> software
> > + * distributed under the License is distributed on an "AS IS"
> BASIS,
> > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> > + * See the License for the specific language governing permissions
> and
> > + * limitations under the License.
> > + */
> 
> There's another header to use now that we're at the ASF. We will need
> to update all the code before the next release (it's the same one used
> elsewhere in the code, "Licensed to ...").


Updated the licenses to that of the new license content on r1028189


> 
> > +
> > +import org.apache.maven.it.Verifier;
> > +import org.apache.maven.it.util.ResourceExtractor;
> > +
> > +import java.io.File;
> > +
> > +public class NPandayITNet40Test
> > +    extends AbstractNPandayIntegrationTestCase
> > +{
> > +    public NPandayITNet40Test()
> > +    {
> > +        super( "[1.0.2,)", "[v4.0.30319,)" );
> 
> This should be [1.2.2-incubating,); it's not supported on earlier
> versions of NPanday (or [2.0-incubating,) if we're going to release
> that next).


Updated the version to "1.2.2-incubating-SNAPSHOT"  on r1028262


> > 
> > Added:
> incubator/npanday/npanday-its/trunk/src/test/resources/Net40Project/ClassLibrary1/Class1.cs
> > URL:
> http://svn.apache.org/viewvc/incubator/npanday/npanday-its/trunk/src/test/resources/Net40Project/ClassLibrary1/Class1.cs?rev=1024204&view=auto
> >
> ==============================================================================
> > ---
> incubator/npanday/npanday-its/trunk/src/test/resources/Net40Project/ClassLibrary1/Class1.cs
> (added)
> > +++
> incubator/npanday/npanday-its/trunk/src/test/resources/Net40Project/ClassLibrary1/Class1.cs
> Tue Oct 19 11:26:56 2010
> > @@ -0,0 +1,11 @@
> > +using System;
> > +using System.Collections.Generic;
> > +using System.Linq;
> > +using System.Text;
> > +
> > +namespace ClassLibrary1
> > +{
> > +    public class Class1
> > +    {
> > +    }
> > +}
> 
> Should this use some .NET 4.0 feature to ensure it works?


Added TimeSpan.ParseExact() to show a .net 4.0 feature on r1028262


> 
> - Brett
> 
> --
> Brett Porter
> br...@apache.org
> http://brettporter.wordpress.com/

Thanks,

liit

Reply via email to