Hi Brett,

----- "Brett Porter" <br...@apache.org> wrote:

> On 20/10/2010, at 4:14 PM, apadi...@apache.org wrote:
> 
> > +    public NPandayIT330MVC2010ProjectTest()
> > +    {
> > +        super( "[1.2,)", "[v4.0.30319,)" ); 
> 
> This version range should be higher as in other cases.


version changed to 1.2.2.-incubating-SNAPSHOT.


> 
> > +
> > +        File f = new File( System.getenv( "SYSTEMROOT" ),
> "assembly/GAC_MSIL/System.Web.MVC" );
> > +        if ( !f.exists() || !f.isDirectory() )
> > +        {
> > +            skipReason = "MVC.NET is not installed";
> > +            skip = true;
> > +        }
> 
> Is this correct for VS 2010 only? I think it was using a different GAC
> location?


This is still the same location for the MVC library.


> > 
> > Added:
> incubator/npanday/npanday-its/trunk/src/test/resources/NPanday330MVC2010ProjectTest/NPanday330MVC2010ProjectTest/Models/AccountModels.cs
> > URL:
> http://svn.apache.org/viewvc/incubator/npanday/npanday-its/trunk/src/test/resources/NPanday330MVC2010ProjectTest/NPanday330MVC2010ProjectTest/Models/AccountModels.cs?rev=1024525&view=auto
> >
> ==============================================================================
> > ---
> incubator/npanday/npanday-its/trunk/src/test/resources/NPanday330MVC2010ProjectTest/NPanday330MVC2010ProjectTest/Models/AccountModels.cs
> (added)
> > +++
> incubator/npanday/npanday-its/trunk/src/test/resources/NPanday330MVC2010ProjectTest/NPanday330MVC2010ProjectTest/Models/AccountModels.cs
> Wed Oct 20 05:14:10 2010
> 
> Do we need that much sample code for the IT? Not sure where it came
> from, is it a generated template project? It seems unclear if some of
> the later AJAX code is actually able to be checked in here.


I'll include 2 or 3 ITs for the VS2010 and .net 4.0 support.


> 
> > +    [PropertiesMustMatch("Password", "ConfirmPassword",
> ErrorMessage = "The password and confirmation password do not
> match.")]
> > +    public class RegisterModel
> > +    {
> > +        [Required]
> > +  Author: apadilla
> > Date: Wed Oct 20 05:14:10 2010
> > New Revision: 1024525
> 
> This is a bit weird - do you know what happened?


I'm not sure why it has an error here.


> 
> - Brett
> 
> --
> Brett Porter
> br...@apache.org
> http://brettporter.wordpress.com/


Thanks,

liit

Reply via email to