Hi,
Ulf Zibis wrote:
> Hi Jean-Pierre,
>
>
> I've updated the patch to make it dependent from:
> #ifdef POSIXACLS
Which means the result is still bad when Posix ACLs are in use, and
you have to pass all the tests, with and without the Posix ACLs...
So minus one on your quota...
IMHO you are on a wrong track. You are making changes in
build_ownadmin_permissions(), this calls two important remarks :
1) Current users who have files with such ACLs will get a new
interpretation of their ACLs, and I cannot endorse that. If there is
a bug in interpreting such an ACL, the only thing that can be done
is preventing such bad configurations to be created any more.
2) For build_ownadmin_permissions() to be called, either the owner
or the group of the file has to be root. You should never get this
sort of ACL through inheritance by a valid user properly mapped
to a valid Windows user with the same rights. Something is wrong
elsewhere.
You should first try to find out why build_ownadmin_permissions()
was called.
Also, patch chunks like the one below are unrelated to the permissions
issue, they should be taken apart and their motivation clearly stated.
Another minus one on your quota...
@@ -3293,10 +3293,10 @@
int acecnt;
int nace;
le32 special;
- BOOL grppresent;
- BOOL ownpresent;
le32 allowown, allowgrp, allowall;
le32 denyown, denygrp, denyall;
+ BOOL ownpresent;
+ BOOL grppresent;
phead = (const SECURITY_DESCRIPTOR_RELATIVE*)securattr;
Regards
Jean-Pierre
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
ntfs-3g-devel mailing list
ntfs-3g-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
