Hi Jean,
On 04/14/2016 07:04 PM, jean-pierre.an...@wanadoo.fr wrote:
[..]
>
> IMHO there is an error in your proposed patch, the
> short-circuit should only be taken when the argument
> is a log file (i.e. not a full partition or image).
>
> The change :
>
> ok = getvolumedata(ctx, boot.buf);
> }
> - if (!ok)
> + if (!ok) {
> fclose(ctx->file);
> + goto out;
> + }
> }
> if (!ok) {
> /* Not a log file, assume an ntfs device, mount it */
>
> Should be :
>
> ok = getvolumedata(ctx, boot.buf);
> - }
> - if (!ok)
> + if (!ok) {
> + fclose(ctx->file);
> + goto out;
> + }
> + } else {
> fclose(ctx->file);
> + }
> }
> if (!ok) {
> /* Not a log file, assume an ntfs device, mount it */
>
> Attached is the full fixed patch.
>
Thanks for review. You are correct, short-circuit in my patch was wrong.
Please apply your version of corrected patch.
-
Best regards,
Rakesh Pandit
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
ntfs-3g-devel mailing list
ntfs-3g-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ntfs-3g-devel
